Make Journal store delayed strings, so they are computed on-demand #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when demanded This fixes the performance issues in the "greedy traversal" test.
|
Before: After: |
|
Just FYI: |
|
... actually, that's already meant to exist: fsharp/fslang-suggestions#429 |
|
👍 This is great |
|
Not sure why that happened twice... |
moodmosaic
added a commit
that referenced
this pull request
Nov 7, 2017
Make Journal store delayed strings, so they are computed on-demand
No worries, it's now manually merged in 813e1f9 via
|
This was referenced Nov 7, 2017
Merged
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the performance issues in the "greedy traversal" test (#146).
I'm not entirely sure about the change to
PropertyBuilder.CounterExample, but it's not really user-visible (they would be using thecounterexample'action' instead of calling this directly).There's another
stringcall which is not delayed (line 275) as it didn't seem to be a performance issue.