-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 Translate keywords in the teacher manual #5167
Conversation
Ok, so here's the sketch of a plan: maybe I can use a script to translate parse the correct programs, translate them to english and add the curly braces, |
Depends on the fix made in #5175 |
While working on #5167 I realized we weren't parsing some examples properly, which let me to realize that I didn't include the equal sign in comparisons for levels 6 through 11. **How to test** I added some tests that should pass!
…_kw_teacher_manual
Done! All languages done with the exception of zh_Hans. I'm not sure what to do with that one since Chinese speakers don't often use spaces, which makes the parser give up. Not sure about an easy solution here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the super delayed review!
Great job! Really! There only a couple of things I noticed that we could improve:
- The keywords are not "highlighted" if they appear in headings. So, the command
echo
would appear correctly in a<p>
but not if it is a<h4>
:
- I noticed that the word
doens't
appears in many places. Perhaps we could change it with this PR? - There are 2 words which I am sure are not used correctly: 'commando' and 'codes'. They change the meaning of the text. Commando is a military unit and code (programming code) can never be plural by definition. This
Codes using the if commando can get very long
is a hilarious example, which I think should be changed to something like:Using the if command can make the code lines very long
.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
In this PR I want to tackle the translation of keywords in the teacher manual. First, we need to allow the keywords to be translated using the curly brace system we use already in the adventures, that is simple enough to do and requires only the call to a function; after that we need to test the programs inside the yamls in the teacher manual, because when they do have curly braces, sometimes they're not correctly. And third, what do we do with the mess we already have?
For example in Spanish there's a mixture of several methods:
Fixes #4134
How to test