Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Programs count #5278

Merged
merged 56 commits into from
Apr 23, 2024
Merged

💻 Programs count #5278

merged 56 commits into from
Apr 23, 2024

Conversation

Annelein
Copy link
Contributor

@Annelein Annelein commented Mar 18, 2024

Fixes #5193
Fixes #5192
Fixes #1275

This fixes that only the programs which are modified are counted as (for now) programs saved.
This is the new issue for the design that shows this counter (where programs_saved will be changed):

Also solved that only if a program is modified, the confetti button is shown:

Screen.Recording.2024-03-25.at.16.43.26.mov

How to test:

  • Run a program with preview code, make sure it doesn't get added to my-programs
  • Run a program with 'modified code' so not the preview code and make sure it does get added to my programs
  • Remove a program from my programs and make sure the counter and the options in the forms get properly updated

@Felienne
Copy link
Member

Felienne commented Apr 4, 2024

Hi @Annelein! We are somewhat eager to get this PR out. What is the blocker, are we waiting for a design from GIsell or for a review or something else?

@Annelein
Copy link
Contributor Author

Annelein commented Apr 4, 2024

Hi @Annelein! We are somewhat eager to get this PR out. What is the blocker, are we waiting for a design from GIsell or for a review or something else?

Everything is ready but already waiting for the design from Gisel for a long time...

@Felienne
Copy link
Member

Felienne commented Apr 4, 2024

Hi @Annelein! We are somewhat eager to get this PR out. What is the blocker, are we waiting for a design from GIsell or for a review or something else?

Everything is ready but already waiting for the design from Gisel for a long time...

Thanks! I will ping her again. Otherwise we can maybe split of the fix for counting the programs (#5193) from the new design?

@Annelein
Copy link
Contributor Author

Annelein commented Apr 8, 2024

Hi @Annelein! We are somewhat eager to get this PR out. What is the blocker, are we waiting for a design from GIsell or for a review or something else?

Everything is ready but already waiting for the design from Gisel for a long time...

Thanks! I will ping her again. Otherwise we can maybe split of the fix for counting the programs (#5193) from the new design?

I will because the design is still not what we are looking for I think, see #5192 (comment)

@Annelein Annelein marked this pull request as ready for review April 8, 2024 11:42
@Annelein Annelein requested review from jpelay and Felienne April 8, 2024 11:55
@Annelein
Copy link
Contributor Author

Annelein commented Apr 8, 2024

@jpelay could you look at the code if there is something I'm doing wrong? Becaus is_program_modified() returns True for this program:

Screen.Recording.2024-04-08.at.13.59.01.mov

Other than that, I think this is ready, apart from the design, that will be done in a new PR.

@jpelay
Copy link
Member

jpelay commented Apr 17, 2024

@Annelein Just made a few changes! Hope that it works now

@Annelein
Copy link
Contributor Author

@jpelay works amazing thank you so much!!! Only thing left is that when a program is removed, the program count is not updated right away, pinging @hasan-sh if he could help me with implementing auto save?

@Annelein Annelein requested review from hasan-sh and removed request for Felienne April 22, 2024 10:30
@Annelein Annelein marked this pull request as ready for review April 22, 2024 10:30
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!!!! 🥳🎉🎊 Can you test a bit on alpha and check that everything works fine?

Copy link
Contributor

mergify bot commented Apr 23, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1e9ef65 into main Apr 23, 2024
12 checks passed
@mergify mergify bot deleted the programs-count branch April 23, 2024 15:57
@Annelein
Copy link
Contributor Author

It works!!!! 🥳🎉🎊 Can you test a bit on alpha and check that everything works fine?

I will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants