-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 Programs count #5278
💻 Programs count #5278
Conversation
Hi @Annelein! We are somewhat eager to get this PR out. What is the blocker, are we waiting for a design from GIsell or for a review or something else? |
Everything is ready but already waiting for the design from Gisel for a long time... |
Thanks! I will ping her again. Otherwise we can maybe split of the fix for counting the programs (#5193) from the new design? |
I will because the design is still not what we are looking for I think, see #5192 (comment) |
for more information, see https://pre-commit.ci
@jpelay could you look at the code if there is something I'm doing wrong? Becaus Screen.Recording.2024-04-08.at.13.59.01.movOther than that, I think this is ready, apart from the design, that will be done in a new PR. |
@Annelein Just made a few changes! Hope that it works now |
for more information, see https://pre-commit.ci
… programs-count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!!!! 🥳🎉🎊 Can you test a bit on alpha and check that everything works fine?
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
I will! |
Fixes #5193
Fixes #5192
Fixes #1275
This fixes that only the programs which are modified are counted as (for now) programs saved.
This is the new issue for the design that shows this counter (where programs_saved will be changed):
Also solved that only if a program is modified, the confetti button is shown:
Screen.Recording.2024-03-25.at.16.43.26.mov
How to test: