Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Rephrasing level 2 is command adventure #5470

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

MarleenGilsing
Copy link
Collaborator

@MarleenGilsing MarleenGilsing commented Apr 25, 2024

favorite_animal instead of favorite_animals

fixes #5461

@MarleenGilsing MarleenGilsing added the Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times label Apr 25, 2024
@MarleenGilsing
Copy link
Collaborator Author

MarleenGilsing commented Apr 25, 2024

The issue has been resolved for all languages (for as far as it was still in English, or I could understand the language). I did notice one strange thing:

This was the Swedish translation of level 2:
image

It states in the text that the example code uses the variable favorite_animals, but the example code doesn't use favorite_animals. It uses favoritdjur. This is confusing for students and happened in quite a lot of languages. I think this might happen because weblate only shows the translators a small part of the page to translate, so they don't see the context of their translations. Might be worth looking into, if this happens more often?

In this case, and the others I found, i already fixed it of course.

@MarleenGilsing MarleenGilsing changed the title Rephrasing level 2 is command adventure 📜 Rephrasing level 2 is command adventure Apr 25, 2024
@Felienne
Copy link
Member

The issue has been resolved for all languages (for as far as it was still in English, or I could understand the language). I did notice one strange thing:

This was the Swedish translation of level 2: image

It states in the text that the example code uses the variable favorite_animals, but the example code doesn't use favorite_animals. It uses favoritdjur. This is confusing for students and happened in quite a lot of languages. I think this might happen because weblate only shows the translators a small part of the page to translate, so they don't see the context of their translations. Might be worth looking into, if this happens more often?

In this case, and the others I found, i already fixed it of course.

Good find and yes that is certainly a limitation of Weblate that it does not show texts together :(

Copy link
Contributor

mergify bot commented Apr 25, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9186f51 into main Apr 25, 2024
12 checks passed
@mergify mergify bot deleted the 5461-rephrase-level-2 branch April 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📜 Improve phrasing in level 2 example
2 participants