Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fix level dropdown in custom-adventure page #5660

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

hasan-sh
Copy link
Contributor

@hasan-sh hasan-sh commented Jul 9, 2024

fixing:

Screen_Recording_2024-07-08_at_16.58.43.mov

How to test?

  • deselect all levels of an adventure,
  • an alert about not selecting any level should appear

@Annelein Annelein self-requested a review July 9, 2024 12:34
@Annelein
Copy link
Contributor

Annelein commented Jul 9, 2024

@hasan-sh the console error is gone, thats good! But do we want it to throw an error if there is no level selected in an adventure? Is it not fine if there is no level selected?

And the error message is: "This Hedy level is invalid." But thats not really the case because there is no level selected so how can it be invalid, "there is no level selected" should be the error message I guess?

Correct me if I'm wrong or you don't agree!

@hasan-sh
Copy link
Contributor Author

hasan-sh commented Jul 9, 2024

@hasan-sh the console error is gone, thats good! But do we want it to throw an error if there is no level selected in an adventure? Is it not fine if there is no level selected?

And the error message is: "This Hedy level is invalid." But thats not really the case because there is no level selected so how can it be invalid, "there is no level selected" should be the error message I guess?

Correct me if I'm wrong or you don't agree!

Correct. This should be defintely handled in the front-end as well and this was the case when we used the tailwind-elements and should be present in the custom-hedy select.

@Annelein
Copy link
Contributor

Correct. This should be defintely handled in the front-end as well and this was the case when we used the tailwind-elements and should be present in the custom-hedy select.

@hasan-sh ok, so this PR is ready for now and its handled in #5540?

Copy link
Contributor

mergify bot commented Jul 10, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 72f8253 into main Jul 10, 2024
12 checks passed
@mergify mergify bot deleted the fix-level-dropdown branch July 10, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants