Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Allow comments to be indented #3287 #5685

Merged
merged 2 commits into from
Aug 6, 2024
Merged

🪲 Allow comments to be indented #3287 #5685

merged 2 commits into from
Aug 6, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko commented Aug 5, 2024

Fixes #3287
The PR addresses multiple small issues related to comments and trailing spaces. Automated tests are added for all scenarios.

How to test

  1. Indented comments and comments at the end of code blocks should work in levels 9-11 without errors:
repeat 3 times
    # comment
    print ‘3’ # another comment
  1. The print command should be able to print a # sign in levels 4-18:
print 'comments start with the # sign'
  1. Equality checks should preserve the original whitespacing of its arguments in levels 8-11. The following program should print the value of i.
i = this   is
print '[' i ']'
if i = ‘this   is’
  print i

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works and I agree with the changes! Great work! You may tell me if you want to approve this now or after #5676

Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 797b86b into main Aug 6, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the comments_3287 branch August 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Comments at indented code-block not allowed.
2 participants