Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Improvements to Teacher's Dashboard #5706

Merged
merged 12 commits into from
Aug 21, 2024
Merged

💻 Improvements to Teacher's Dashboard #5706

merged 12 commits into from
Aug 21, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Aug 19, 2024

This PR improves the dashboard in several aspects:

  1. Responsiveness: If you try to use the dashboard from a mobile phone, it will appear like this: the buttons are way too big, the first row is crammed, and the graph looks weird.

image

This is how it looks now:

image
image

  1. Adds a new table for student's information, and also I moved the Actions buttons there, leaving the adventure table only for ticking the checkmarks. I think that cramming everything into a single table would've been a lot harder and clumsier.

image

  1. Since I'm adding another table, and to avoid confusion, I added a little explanation on top of each one, so teachers can know the reason for having two of them.

  2. The delete student button deleted the student, but you had to manually recharge the page to make the changes visible. Now each time you delete a student we use HTMX to reload the tables and the graph.

Fixes #4243
Fixes #5702

@jpelay jpelay changed the title 💻 Changes dashboard 💻 Improvements to Teacher's Dashboard Aug 19, 2024
Copy link
Contributor

mergify bot commented Aug 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 65d1386 into main Aug 21, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Aug 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the changes_dashboard branch August 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲Deleting student from class, doesn't update the table [UI idea] Grid: show in class overview
2 participants