Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Add support for more quotes #5791

Merged
merged 3 commits into from
Sep 20, 2024
Merged

🪲 Add support for more quotes #5791

merged 3 commits into from
Sep 20, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

Fixes #5785
We already support multiple types of quotes for strings, but we were missing a few. A Polish translator got the build failing because they used a variation of double quotes that we do not support.
This PR adds support for:

  • Polish variation of double quotes: „”
  • Swedish/Finish variation of double quotes: ””
  • Korean quotes: 《》
  • Japanese quotes: 「」

How to test
In level 4, the following print statements should work without an error:

print „pol”
print ”swe”
print 《kor》
print 「jap」

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the quotes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file caused translation tests to fail (when the cache is switched off locally). I will investigate why there is no failure on GitHub, but I suspect it is caching.

Copy link
Contributor

mergify bot commented Sep 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c6e2d43 into main Sep 20, 2024
12 checks passed
@mergify mergify bot deleted the quotes_5785 branch September 20, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲Add support for Polish quotation marks
2 participants