📜 Adds workbooks in en and nl #5879
Conversation
for more information, see https://pre-commit.ci
…o nicer-workbooks
Felienne
changed the title
|
Setting this to draft, since I have to still add the translation defaults to weblate! |
|
I added one key to show what I mean, if you understand how to finish this, please do (if not, I will do it maybe today or otherwise next week) |
I added the strings for translation and fixed some content issues which caused a validation failure. Please check my translation of the question titles and descriptions. I thought the only thing left for this PR is the Weblate work but it seems that the workbooks are not functional yet, is this correct? I am not sure I can take over the whole task because I lack the details, but if there is more work that you can delegate to me, just let me know. |
Thanks for fixing the keys! The workbooks should be operational, via this link: http://127.0.0.1:8080/for-teachers/workbooks/1 Does that work for you? If so, you can make the needed Weblate changes and approve! |
* Translated using Weblate (Serbian) Currently translated at 84.4% (1846 of 2185 strings) Translated using Weblate (Serbian) Currently translated at 96.5% (721 of 747 strings) Co-authored-by: Reno Tx <[email protected]> Translate-URL: https://hosted.weblate.org/projects/hedy/adventures/sr/ Translate-URL: https://hosted.weblate.org/projects/hedy/quizzes/sr/ Translation: Hedy/Adventures Translation: Hedy/Quizzes * 🤖 Automatically update generated files * Address sr weblate errors --------- Co-authored-by: Reno Tx <[email protected]> Co-authored-by: weblate <[email protected]>
Translations update from [Hosted Weblate](https://hosted.weblate.org) for [Hedy/Adventures](https://hosted.weblate.org/projects/hedy/adventures/). It also includes following components: * [Hedy/Tutorials](https://hosted.weblate.org/projects/hedy/tutorials/) * [Hedy/Parsons](https://hosted.weblate.org/projects/hedy/parsons/) * [Hedy/Webpages](https://hosted.weblate.org/projects/hedy/webpages/) * [Hedy/Texts](https://hosted.weblate.org/projects/hedy/web-texts/) * [Hedy/Quizzes](https://hosted.weblate.org/projects/hedy/quizzes/) * [Hedy/Cheatsheets](https://hosted.weblate.org/projects/hedy/commands/) * [Hedy/Keywords](https://hosted.weblate.org/projects/hedy/keywords/) * [Hedy/client-messages](https://hosted.weblate.org/projects/hedy/client-messages/) * [Hedy/slides](https://hosted.weblate.org/projects/hedy/slides/) Current translation status:  Co-Authored-By: Kamborio <[email protected]>
Adds info to all the languages (did it the old fashioned copy/paste way, because I think boryana is still working on weblate). When doing this i found some weird yalms for some languages. I don't know if you already knew about this @Felienne, but: kab: the whole yaml is upside down for some reason ne & uz: does not have a teachers guide, whole sections missing ta: empty file, just contains {} Fixes #4955 Co-Authored-By: Boryana Goncharenko <[email protected]>
Translations update from [Hosted Weblate](https://hosted.weblate.org) for [Hedy/Adventures](https://hosted.weblate.org/projects/hedy/adventures/). It also includes following components: * [Hedy/Quizzes](https://hosted.weblate.org/projects/hedy/quizzes/) * [Hedy/Cheatsheets](https://hosted.weblate.org/projects/hedy/commands/) * [Hedy/Webpages](https://hosted.weblate.org/projects/hedy/webpages/) * [Hedy/Texts](https://hosted.weblate.org/projects/hedy/web-texts/) * [Hedy/Parsons](https://hosted.weblate.org/projects/hedy/parsons/) * [Hedy/slides](https://hosted.weblate.org/projects/hedy/slides/) * [Hedy/Keywords](https://hosted.weblate.org/projects/hedy/keywords/) * [Hedy/Tutorials](https://hosted.weblate.org/projects/hedy/tutorials/) * [Hedy/client-messages](https://hosted.weblate.org/projects/hedy/client-messages/) Current translation status:  Co-Authored-By: Kamborio <[email protected]>
There was a problem hiding this comment.
LGTM! Just 2 things to note:
- There are some UI improvements that we can do for the workbooks, e.g. the radio buttons for correct/incorrect are not aligned etc. I will create a separate issue to iterate on the UI.
- For the English translation of the workbooks, I am certain we cannot use
codes. The word (software) code is uncountable and should always appear in a singular form. If used as a countable noun, the word means non-software code e.g. crack the code, a strict code of conduct. I changed all instances of 'codes' to either 'programs' or just 'code'. Jesus and I recently corrected this in multiple other places. If you do not agree with this change, please let us know so that we stop correcting it.
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Adds workbooks to pages
How to test
Follow these steps to verify this PR works as intended: