🧹 Add checks for duplicate HTML element IDs #6055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the course of investigating other issues, I've found that we are emitting invalid HTML. For example, multiple elements with the same `id="..."` attribute. This doesn't cause loud errors in the browser, but interferes with the proper functioning HTML selectors and Cypress tests don't always behave like they should. Add the start of a postprocessing step where we are going to validate the HTML that is generated in Flask templates and crash loudly if it is illegal.
for more information, see https://pre-commit.ci
…eck-duplicate-ids
for more information, see https://pre-commit.ci
…heck-duplicate-ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of investigating other issues, I've found that we are emitting invalid HTML. For example, multiple elements with the same
id="..."attribute.This doesn't cause loud errors in the browser, but interferes with the proper functioning HTML selectors and Cypress tests don't always behave like they should.
Add the start of a postprocessing step where we are going to validate the HTML that is generated in Flask templates and crash loudly if it is illegal.
There are many
id="..."attributes in our HTML that seem like they're not being used at all by TypeScript code or by HTMX annotations, so I write a little script to identify ones that are definitely unused and removed them. This probably leaves a number of unusedidattributes that I couldn't definitely determine as unused, and I don't want to spend time figuring it out for each of them because there are loads.How to test
This currently breaks the tests because we have illegal templates, but I need to go through this at a later time.