-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Remove global variables from syntax highlighter #6085
Open
rix0rrr
wants to merge
18
commits into
main
Choose a base branch
from
huijbers/no-global-trans
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,046
−926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax highlighter used to work by calling `initTranslations()` with the current level and language, which then manipulates global variables so that the syntax highlighter code has the right information to highlight the different levels and languages of Hedy correctly. To remove the need for global variables, we instead parameterize the Lezer parsers and pass the level and language into the generator at every time it is used.
for more information, see https://pre-commit.ci
boryanagoncharenko
approved these changes
Jan 6, 2025
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax highlighter used to work by calling
initTranslations()
with the current level and language, which then manipulates global variables so that the syntax highlighter code has the right information to highlight the different levels and languages of Hedy correctly.To remove the need for global variables, we instead parameterize the Lezer parsers and pass the level and language into the generator at every time it is used.
The old parser code looked like this:
extendKeyword
depends on language and level, and so what we used to do is put the "current" language and level in a global variable and read the global variable inextendKeyword
. This creates a sequencing requirement via global state, and apparently also a race condition because sometimes the syntax highlighters didn't load properly (see #6024).In this PR, I change the generated source files to look like this:
This PR is a cleanup task from another larger PR I'm doing, that I'd like to separate out.
It also happens to fix #6024 😉
How to test
This shouldn't change anything.