Add latest ruleset page #98
Conversation
| }, | ||
|
|
||
| data() { | ||
| return { |
There was a problem hiding this comment.
Because JS, and particularly Vue, is not our "normal" work, I think we should try to be especially diligent about adding comments / docstrings to methods. What seems obvious today, might be obscure in a months time.
There was a problem hiding this comment.
I agree but for this one I think that it's not necessary to add comment.
The data property is the main important things to know in Vue, it's for that reason that I didn't add comment, for example, it's like adding comment on top of the main function in a Go program.
There was a problem hiding this comment.
There are eslint errors:
You don;t have to fix them by hand though:
Could you install these VS Code plugins please?:
eslintvetur
And enable these lines in your settings:
"eslint.autoFixOnSave": true"vetur.format.defaultFormatter.js": "prettier-eslint"
It should fix all of these formatting issues on save.
Also, the rules are still editable. Even though it doesn't change data on the server, it's poor UX. We should only display the rules without being able to change them.
@asdine are you sure? Because in my machine the rules aren't editable thanks to the Thank you for the plugin suggestion, I installed them, but the errors aren't fixed on saving. |
|
@asdine 🆙
|
There is something that bothers me, now the "/" from the URL are encoded because of the separator in the path.
For the given ruleset path:
boost/hidden/v2, the vuejs's router think that it's an endpoint instead of a path in the router declaration thus the/rulesets/:path/latestwon't be reached.Can we do something to avoid that?
This PR fixes #32.