Moving commit QC into log entries #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmy
reviewed
Nov 25, 2024
lemmy
reviewed
Nov 25, 2024
| @@ -308,7 +308,7 @@ Timeout(r) == | |||
| /\ matchIndex' = [matchIndex EXCEPT ![r] = [s \in R |-> 0]] | |||
| /\ UNCHANGED <<log, crashCommitIndex, byzCommitIndex, byzActions>> | |||
|
|
|||
| \* The view of the highest qc in log l, -1 if log contains no qcs | |||
| \* The view of the highest byzQC in log l, -1 if log contains no qcs | |||
There was a problem hiding this comment.
second "qcs" at the end of the comment.
lemmy
reviewed
Nov 26, 2024
lemmy
reviewed
Nov 26, 2024
pirateship.tla
Outdated
| @@ -184,6 +184,24 @@ MaxQuorum(l, m, default) == | |||
| THEN i ELSE RMaxQuorum(i-1) | |||
| IN RMaxQuorum(Len(l)) | |||
|
|
|||
| \* Checks if a log l is well formed e.g. terms are monotonically increasing | |||
There was a problem hiding this comment.
Terminology: "Terms" vs. "Views"
lemmy
reviewed
Nov 26, 2024
heidihoward
changed the title
|
The CI is red but this is due to another reason so I'm going to go ahead and merge this change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing as the byz commit can front run the crash commit. This is a side effect of having the crash qc (commit index) in the AE messages. This PR moves the crashQC into log entries themselves.