Seperate MaxQuorums #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies! |
lemmy
reviewed
Nov 28, 2024
| @@ -184,7 +184,15 @@ HighestQCOverQC(l) == | |||
| Max2(a,b) == IF a > b THEN a ELSE b | |||
| Min2(a,b) == IF a < b THEN a ELSE b | |||
|
|
|||
| MaxQuorum(l, m, default) == | |||
| MaxCrashQuorum(l, m, default) == | |||
There was a problem hiding this comment.
You could also make the quorum a parameter of MaxCrashQuorum.
MaxQuorum(Q, l, m, default) ==
LET RECURSIVE RMaxQuorum(_)
RMaxQuorum(i) ==
IF i = default THEN default
ELSE IF \E q \in Q: \A n \in q: m[n] >= i
THEN i ELSE RMaxQuorum(i-1)
IN RMaxQuorum(Len(l))
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
The definitions of Lines 68 to 71 in 9a611a4 |
|
You change them when you change the number of replicas. N=4 is a special case where they are the same |
|
I never touched 6a6c862#diff-bb74f8203fb9704ca17cbe4e4b2335f443a4659bed373276a16ccb626a989b81R49-R53 |
|
Sorry I meant to say "You change them" not "You changed them" as in you can change them if you want to vary the number of nodes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug introduced during the refactoring of
MaxQuorum035b5ae#diff-bb74f8203fb9704ca17cbe4e4b2335f443a4659bed373276a16ccb626a989b81L257. These two calculations were using different quorums (CQ for crash quorum and BQ for Byzantine quorum), when they were merged they were both switched to BQCC @lemmy