Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo #1

Closed
wants to merge 3 commits into from
Closed

fix: Fix typo #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eab03d4
Update prometheus-deployment.yaml
heidongxianhua Oct 12, 2023
65bd87b
Update gc_controller_test.go
heidongxianhua Oct 12, 2023
9dceb46
Update ci-build.yaml
heidongxianhua Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ jobs:
run: make ${{matrix.test}} E2E_SUITE_TIMEOUT=20m STATIC_FILES=false

# failure debugging below
- name: Debugging with ssh
uses: lhotari/action-upterm@v1
# if: ${{ failure() }}
- name: Failure debug - describe MinIO/MySQL deployment
if: ${{ failure() }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion manifests/quick-start/base/prometheus/prometheus-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# localhost:9091/graph
#
# Note: this assumes the workflow-controller is emitting metrics in the default port (9090). This will need to
# be modified if the default is overriden.
# be modified if the default is overridden.
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
2 changes: 1 addition & 1 deletion workflow/gccontroller/gc_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ func TestEnqueueWF(t *testing.T) {
assert.Equal(t, 0, controller.workqueue.Len())
}

func TestTTLStrategySucceded(t *testing.T) {
func TestTTLStrategySucceeded(t *testing.T) {
var err error
var un *unstructured.Unstructured
var ten int32 = 10
Expand Down
Loading