Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Handle TMPDIR not being set #48

Merged

Conversation

barchetta
Copy link
Member

Fix the updatehelidonversion.sh script to handle when TMPDIR is not set.

@barchetta barchetta self-assigned this Apr 19, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 19, 2024
@barchetta barchetta merged commit bf63544 into helidon-io:helidon-3.x Apr 19, 2024
6 checks passed
@senivam
Copy link
Member

senivam commented Apr 22, 2024

Excuse me for being late for this PR, but why not to use sed -i <PATTERN> pom.xml pattern and avoid the TMPDIR at all in the script?

barchetta added a commit to barchetta/helidon-examples that referenced this pull request Jul 8, 2024
@barchetta barchetta mentioned this pull request Jul 8, 2024
barchetta added a commit that referenced this pull request Jul 8, 2024
* Exclude status example test for status 171 depending on JDK version (#58)
* 3.x: Handle TMPDIR not being set (#48)

---------

Co-authored-by: Tim Quinn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants