Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update Dockerfiles #50

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented May 10, 2024

This PR:

  1. Removes Dockerfiles from some examples to simplify maintenance and improve consistency. Dockerfiles are still included in the quickstarts
  2. Update Dockerfiles to use jdk-no-fee-term from container-registry.oracle.com instead of openjdk.
  3. Updates base linux image to container-registry.oracle.com/os/oraclelinux:9-slim

Why jdk-no-fee-term?

  1. openjdk stops getting updates after the next version of the JDK is released. jdk-no-fee-term gets updates until one year after the next LTS version (so much longer)
  2. Like the openjdk repo, no login is needed. So user experience should not be impacted.

Tip: if for some reason you run into authentication errors with container-registry.oracle.com (even when accessing repositories that should not require authentication) it might be caused by cached expired credentials mucking up the works. Try this:

docker logout container-registry.oracle.com
rm ~/.docker/config.json

@barchetta barchetta added the 3.x label May 10, 2024
@barchetta barchetta requested a review from romain-grecourt May 10, 2024 15:39
@barchetta barchetta self-assigned this May 10, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@barchetta barchetta changed the title 3.x dockerfile jdk 3.x: Update Dockerfiles May 10, 2024
@barchetta barchetta merged commit 303a5cc into helidon-io:dev-3.x May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants