Exclude status example test for status 171 depending on JDK version #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
approved these changes
Jul 2, 2024
barchetta
pushed a commit
to barchetta/helidon-examples
that referenced
this pull request
Jul 8, 2024
Merged
barchetta
added a commit
that referenced
this pull request
Jul 8, 2024
* Exclude status example test for status 171 depending on JDK version (#58) * 3.x: Handle TMPDIR not being set (#48) --------- Co-authored-by: Tim Quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves helidon-io/helidon#8834
As @tomas-langer noted
https://github.com/helidon-io/helidon/blob/966c7f3d02f8cdbb706f76fb7fb9614f8ea1c4bc/examples/microprofile/http-status-count-mp/src/test/java/io/helidon/examples/mp/httpstatuscount/StatusTest.java#L58-L59
the offending test request does not work with JDK 20 and higher.
This PR adds a bit of logic to retrieve the current JDK version and exclude the offending request for JDK 20 and higher.
With that change, the test works correctly with JDK 17 and 21.