Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for HTTP health checks to gRPC example #87

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Sep 5, 2024

Adds support for HTTP health checks, including a custom one to verify if gRPC endpoint is ready. Relocates resources from test to main. New test.

… if gRPC endpoint is ready. Relocates resources from test to main. New test.
@spericas spericas requested a review from tjquinno September 5, 2024 14:04
@spericas spericas self-assigned this Sep 5, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 5, 2024
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions.

…ss periodically. Use config to init HealthObserver.

Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
@spericas spericas merged commit 58e80fb into helidon-io:dev-4.x Sep 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x grpc OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants