Support Hocon/Json Configuration Source for MP #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Hocon/Json Configuration Source for MP 1. Meta-config is refactored to allow it to be customizable by users for other types. 2. Hocon/Json is parsed as a config source only via meta-config. * Create hocon includer per instance of hocon config source and add justification comment for security bug filtering * Remove support of application.conf/json hocon/json as default discoverable sources * Initial commit for Mp config-source provider implementation * Add MP meta-config provider test for Environment Variables * Add Yaml MP meta-config provider tests and various resolution to review feedback * Add helidon-config-yaml-mp as a dependency of helidon-microprofile-cdi * Declare "uses io.helidon.config.mp.spi.MpMetaConfigProvider" in config-mp’s module-info and set priority of all implementations of MpMetaConfigProvider to 300 * Various updates/cleanups from review feedback * Add helidon-config-yaml dependency to metrics examples after they were failing because of dependency on yaml-mp
tomas-langer
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of 2.x PR: #4218
Create hocon includer per instance of hocon config source and add justification comment for security bug filtering
Remove support of application.conf/json hocon/json as default discoverable sources
Initial commit for Mp config-source provider implementation
Add MP meta-config provider test for Environment Variables
Add Yaml MP meta-config provider tests and various resolution to review feedback
Add helidon-config-yaml-mp as a dependency of helidon-microprofile-cdi
Declare "uses io.helidon.config.mp.spi.MpMetaConfigProvider" in config-mp’s module-info and set priority of all implementations of MpMetaConfigProvider to 300
Various updates/cleanups from review feedback
Add helidon-config-yaml dependency to metrics examples after they were failing because of dependency on yaml-mp