3.x: resolve native-image warnings after Netty upgrade #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
added
dependencies
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
previously approved these changes
Jun 23, 2023
barchetta
force-pushed
the
3.x-netty-native-image
branch
from
a67e37b
to
b61a6a7
Compare
tomas-langer
previously approved these changes
Apr 5, 2024
barchetta
force-pushed
the
3.x-netty-native-image
branch
from
b61a6a7
to
dcf9e3f
Compare
romain-grecourt
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5878
This PR silences warning from native-image caused by Netty metadata providing reflection entries for Netty classes that depend on optional 3rd party dependencies. We silence those warnings by adding the the third party dependencies to our native image extension -- this way they are not part of a non-native image Java build.
Size of native image. This shows native-image executable size did not grow much with the fix.