3.x Make OciMetricsDataTest.beforeEach non private #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
previously approved these changes
Aug 8, 2023
This was referenced Aug 8, 2023
|
We have a common practice to declare all JUnit test classes as package local, and their methods as well. |
Captain1653
force-pushed
the
3-x-private-before-each
branch
from
ec84ca7 to
7159a7c
Compare
|
Done :) |
tjquinno
approved these changes
Aug 8, 2023
romain-grecourt
changed the title
|
Can this PR be merged? Please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a private method with an annotation
BeforeEachinOciMetricsDataTest, butBeforeEach-method must not be private .I made it public (or it can be without an access modificator). Also small refactoring.
P.S. It's interesting. The private
BeforeEach-method also works. I didn't expect it. It's better to follow the docs.