OCI Global Config Source #7352
Merged
OCI Global Config Source #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
trentjeff
added
3.x
trentjeff
requested review from
tomas-langer,
ljnelson,
romain-grecourt,
barchetta and
arjav-desai
tomas-langer
requested changes
Aug 10, 2023
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
requested changes
Aug 10, 2023
.../src/main/java/io/helidon/integrations/oci/sdk/runtime/OciAuthenticationDetailsProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/helidon/integrations/oci/sdk/runtime/OciAuthenticationDetailsProvider.java
Outdated
Show resolved
Hide resolved
...ci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciConfigBlueprint.java
Outdated
Show resolved
Hide resolved
.../test/java/io/helidon/integrations/oci/sdk/runtime/OciAuthenticationDetailsProviderTest.java
Show resolved
Hide resolved
...ons/oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciConfigTest.java
Outdated
Show resolved
Hide resolved
...ons/oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciConfigTest.java
Outdated
Show resolved
Hide resolved
...ons/oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciConfigTest.java
Outdated
Show resolved
Hide resolved
...ons/oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciConfigTest.java
Outdated
Show resolved
Hide resolved
...ons/oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciConfigTest.java
Outdated
Show resolved
Hide resolved
arjav-desai
reviewed
Aug 10, 2023
| * | ||
| * @return the bootstrap oci config bean | ||
| * @see OciConfigBlueprint | ||
| */ | ||
| public static OciConfig ociConfig() { |
There was a problem hiding this comment.
It seems like any app/api that wants to make calls to OCI will need to call this method first and then use the config to create auth details etc. We should look at doing this only once and not read file/default source to create config object again.
This was referenced Aug 10, 2023
ljnelson
reviewed
Aug 11, 2023
...ci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciConfigBlueprint.java
Show resolved
Hide resolved
ljnelson
reviewed
Aug 11, 2023
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Aug 14, 2023
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Show resolved
Hide resolved
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
integrations/oci/sdk/runtime/src/test/resources/test-oci-config-file.yaml
Outdated
Show resolved
Hide resolved
tomas-langer
requested changes
Aug 14, 2023
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Show resolved
Hide resolved
There was a problem hiding this comment.
@ljnelson you have unresolved issues, please do the last approval
...ions/oci/sdk/runtime/src/main/java/io/helidon/integrations/oci/sdk/runtime/OciExtension.java
Outdated
Show resolved
Hide resolved
ljnelson
previously approved these changes
Aug 14, 2023
As requested |
tomas-langer
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement for issue #7348.