Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Makes SecretBundleConfigSource public; improves modification logic #7468

Merged
merged 2 commits into from
Aug 25, 2023
Merged

3.x: Makes SecretBundleConfigSource public; improves modification logic #7468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a06c3f
3.x: Makes SecretBundleConfigSource public; improves modification log…
ljnelson Aug 25, 2023
a6275b5
Squashable commit; eliminates spurious lambda
ljnelson Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/oci/oci-secrets-config-source/etc/spotbugs/exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">

<Match>
<Class name="io.helidon.integrations.oci.secrets.configsource.OciSecretsConfigSourceProvider$SecretBundleConfigSource"/>
<Class name="io.helidon.integrations.oci.secrets.configsource.SecretBundleConfigSource"/>
<Method name="secretSummaries"/>
<!-- Spotbugs is very, very confused by try-with-resources blocks. -->
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
Expand Down
Loading