Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix parent for TestNG project #7616

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[3.x] Fix parent for TestNG project #7616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94a4dce
Fix parent for TestNG project
dalexandrov Sep 18, 2023
78e0e10
Fix JavaDoc
dalexandrov Sep 19, 2023
45849a4
Fix Checkstyle
dalexandrov Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions microprofile/tests/testng/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>tests-project</artifactId>
<groupId>io.helidon.microprofile.tests</groupId>
<groupId>io.helidon.microprofile</groupId>
<artifactId>helidon-microprofile-project</artifactId>
<version>3.2.3-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>


<groupId>io.helidon.microprofile.tests</groupId>
<artifactId>helidon-microprofile-tests-testng</artifactId>
<name>Helidon Microprofile Tests TestNG</name>

Expand Down
4 changes: 2 additions & 2 deletions ...rofile/tests/testng/src/main/java/io/helidon/microprofile/tests/testng/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022 Oracle and/or its affiliates.
* Copyright (c) 2022, 2023 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -33,7 +33,7 @@
* If set to {@code true}, the existing (or default) MicroProfile configuration would be used.
* By default uses a configuration constructed using all {@link AddConfig}
* annotations and {@link #configSources()}.
* When set to false and a {@link org.junit.jupiter.api.BeforeAll} method registers a custom configuration
* When set to false and a {@link org.testng.annotations.BeforeClass} method registers a custom configuration
* with {@link org.eclipse.microprofile.config.spi.ConfigProviderResolver}, the result is undefined, though
* tests have shown that the registered config may be used (as BeforeAll ordering is undefined by
* JUnit, it may be called after our extension)
Expand Down
Loading