Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] archetypes does not offer a metrics provider choice for custom/se #7638

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[3.x] archetypes does not offer a metrics provider choice for custom/se #7638

merged 2 commits into from
Sep 21, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Sep 20, 2023

Description

fix #7557

I backported critical changes about testing and compatibility.
#7508
#7176

Documentation

no impact

@tvallin
fix archetype build (helidon-io#7177)
6afc73d 
Signed-off-by: tvallin <[email protected]>
(cherry picked from commit 48511c3)
@tvallin
remove metrics provider for SE
eeff142 
Signed-off-by: tvallin <[email protected]>
@tvallin tvallin added 3.x Issues for 3.x version branch archetypes labels Sep 20, 2023
@tvallin tvallin requested a review from tjquinno September 20, 2023 14:03
@tvallin tvallin self-assigned this Sep 20, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 20, 2023
tjquinno
tjquinno approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I built your branch locally and ran helidon init and the metrics dialog is much better.

@tvallin tvallin merged commit 04f7e54 into helidon-io:helidon-3.x Sep 21, 2023
12 checks passed
@tvallin tvallin deleted the archetype-provider branch September 21, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees

@tvallin tvallin

Labels
3.x Issues for 3.x version branch archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.x] archetypes should not offer a metrics provider choice for custom/se
2 participants
@tvallin @tjquinno