Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Examples validation flow for external examples repo #7889

Merged

Conversation

senivam
Copy link
Member

@senivam senivam commented Oct 25, 2023

Description

The validation flow which will be used after examples are moved to the external repository

Documentation

GitHub actions change which will build examples from the external repository on any PR that relates to helidon-3.x
The validation is not falling so if the build does not pass (examples vs helidon PR), PR still can be merged but related checks will become red to warn the developer that something went wrong.

@senivam senivam added examples build 3.x Issues for 3.x version branch labels Oct 25, 2023
@senivam senivam self-assigned this Oct 25, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 25, 2023
@senivam senivam changed the title Examples validation flow for external examples repo 3.x Examples validation flow for external examples repo Oct 25, 2023
@senivam
Copy link
Member Author

senivam commented Oct 25, 2023

image

This how it shall look when examples fail but PR can be still merged

@senivam senivam force-pushed the 3x_examples_validation branch 2 times, most recently from 034ce0f to 48e7c05 Compare February 28, 2024 13:43
@barchetta barchetta marked this pull request as ready for review February 28, 2024 16:39
@romain-grecourt romain-grecourt merged commit b97e099 into helidon-io:helidon-3.x Mar 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch build examples OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants