Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] - Add generated source folder #7921

Conversation

dalexandrov
Copy link
Contributor

Resolves #7870

@dalexandrov dalexandrov added bug Something isn't working docs 4.x Version 4.x labels Oct 31, 2023
@dalexandrov dalexandrov requested a review from barchetta October 31, 2023 10:34
@dalexandrov dalexandrov self-assigned this Oct 31, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 31, 2023
@dalexandrov dalexandrov requested review from romain-grecourt and helidonrobot and removed request for helidonrobot November 1, 2023 10:47
@@ -255,6 +255,7 @@
<version>${version.plugin.javadoc}</version>
<configuration>
<source>${version.java}</source>
<sourcepath>src/main/java;target/generated-sources</sourcepath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the aggregated javadocs do not build at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, builds on my machine!

Copy link
Member

@barchetta barchetta Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run mvn site I do not see javadocs being generated:

$ rm -rf target
$ mvn site
$ du -sh target/site/apidocs
du: target/site/apidocs: No such file or directory

If I remove the change in this PR then javadocs are generated.

@dalexandrov dalexandrov force-pushed the 7870_add_generated_javadoc_source branch from 7748f58 to 342dc3f Compare November 3, 2023 08:24
Signed-off-by: Dmitry Aleksandrov <[email protected]>
@dalexandrov dalexandrov force-pushed the 7870_add_generated_javadoc_source branch from 342dc3f to 4bbcc60 Compare November 6, 2023 09:56
@dalexandrov dalexandrov deleted the 7870_add_generated_javadoc_source branch November 22, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x: Missing javadocs for io.helidon.webserver.WebServerConfig.Builder
2 participants