Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: ErrorHandlers class swallows exception object if response can't be reset #8634

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Apr 9, 2024

Description

#8021

Documentation

Probably we don't want to log the exception in the logger as a warning, but I understand it could be useful to include the root exception in the cause.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 9, 2024
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Copy link
Member Author

jbescos commented Apr 10, 2024

Can you add a test for this?

Done

@jbescos jbescos merged commit df16682 into helidon-io:main Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants