Add back and enhance the page describing OpenAPI generation for Helidon 4 #9052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@romain-grecourt Note there are some extra lines in some files. I'll be pushing a better commit shortly. |
docs/src/main/java/io/helidon/docs/se/openapi/OpenApiGeneratorSnippets.java
Outdated
Show resolved
Hide resolved
…de generators Signed-off-by: Tim Quinn <[email protected]>
…or each of SE and MP
romain-grecourt
force-pushed
the
4.x-openapi-gen-se-doc
branch
from
ce2a0c2 to
21c3eb5
Compare
docs/src/main/java/io/helidon/docs/se/openapi/OpenApiGeneratorSnippets.java
Show resolved
Hide resolved
docs/src/main/java/io/helidon/docs/mp/openapi/OpenApiGeneratorSnippets.java
Outdated
Show resolved
Hide resolved
…s.java
- Inline table of content from includes/openapi/openapi-generator.adoc to remove warning
- Remove unused attribute {snippets}
- Add new line at EOF in se/openapi/openapi-generator.adoc
- Remove empty line in mp/openapi/openapi-generator.adoc
romain-grecourt
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #8879 and #8880.
This PR
is a follow-up tosupercedes and includes equivalent changes for PR #8796 which documented how to use the Helidon 4 generators for MPand is still awaiting review and approval.We should not merge this PR--in fact, the docs component build will not pass for this PR--until the OpenAPITools project releases the generator that contains the changes to support Helidon 4 SE. See OpenAPITools/openapi-generator#19150. We are aiming for 7.8.0 and the change todependencies/pom.xmlin this PR reflects that.In its current form which does not run the generators this PR can be merged without waiting for a release of the OpenAPITools project. My OpenAPITools PR has been approved and merged so the enhancements should be available at the release of 7.8.0 targeted for 9 Aug.
Documentation
This is a doc-only PR.