-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Update to static content #9502
Merged
tomas-langer
merged 8 commits into
helidon-io:main
from
tomas-langer:9471-static-content
Nov 25, 2024
Merged
4.x: Update to static content #9502
tomas-langer
merged 8 commits into
helidon-io:main
from
tomas-langer:9471-static-content
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WebServer feature to support static content from configuration - new Builder API based prototypes to configure it - deprecated old approach
Added singular methods for classpath and path handlers. Renamed welcome file to welcome to align with current MP configuration option.
update to deprecated usages to avoid compiler warnings.
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Nov 14, 2024
Fix configuration used in MP extension.
spericas
reviewed
Nov 21, 2024
spericas
reviewed
Nov 21, 2024
spericas
reviewed
Nov 21, 2024
spericas
reviewed
Nov 21, 2024
spericas
reviewed
Nov 21, 2024
...tic-content/src/main/java/io/helidon/webserver/staticcontent/BaseHandlerConfigBlueprint.java
Show resolved
Hide resolved
spericas
reviewed
Nov 21, 2024
...tic-content/src/main/java/io/helidon/webserver/staticcontent/MemoryCacheConfigBlueprint.java
Outdated
Show resolved
Hide resolved
spericas
previously approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments are pretty minor, no need to block this PR
…r to Java's Duration, but for size in bytes). Update to builder to support nice defaults for size. Update to PR to fix comments, and use Size for memory cache capacity.
spericas
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Dec 4, 2024
* Static content update - WebServer feature to support static content from configuration - new Builder API based prototypes to configure it - deprecated old approach * Use defaults for sockets and welcome file. Added singular methods for classpath and path handlers. Renamed welcome file to welcome to align with current MP configuration option. * CDI extension update to use new API with same defaults, update to deprecated usages to avoid compiler warnings. * Documentation update for MP and SE. * Fix classpath root cleanup. Fix configuration used in MP extension. * Introduction of io.helidon.common.Size to handle size strings (similar to Java's Duration, but for size in bytes). Update to builder to support nice defaults for size. Update to PR to fix comments, and use Size for memory cache capacity.
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Dec 4, 2024
* Static content update - WebServer feature to support static content from configuration - new Builder API based prototypes to configure it - deprecated old approach * Use defaults for sockets and welcome file. Added singular methods for classpath and path handlers. Renamed welcome file to welcome to align with current MP configuration option. * CDI extension update to use new API with same defaults, update to deprecated usages to avoid compiler warnings. * Documentation update for MP and SE. * Fix classpath root cleanup. Fix configuration used in MP extension. * Introduction of io.helidon.common.Size to handle size strings (similar to Java's Duration, but for size in bytes). Update to builder to support nice defaults for size. Update to PR to fix comments, and use Size for memory cache capacity.
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Dec 11, 2024
* Static content update - WebServer feature to support static content from configuration - new Builder API based prototypes to configure it - deprecated old approach * Use defaults for sockets and welcome file. Added singular methods for classpath and path handlers. Renamed welcome file to welcome to align with current MP configuration option. * CDI extension update to use new API with same defaults, update to deprecated usages to avoid compiler warnings. * Documentation update for MP and SE. * Fix classpath root cleanup. Fix configuration used in MP extension. * Introduction of io.helidon.common.Size to handle size strings (similar to Java's Duration, but for size in bytes). Update to builder to support nice defaults for size. Update to PR to fix comments, and use Size for memory cache capacity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
enhancement
New feature or request
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
webserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9471
Description
This PR introduces static content Server feature. This allows us to configure static content in config, with multiple handlers supported (both for
path
andclasspath
based static content).The new configuration is using Helidon builders, and I have added the Config metadata plugin to have the reference available.
Old approach is deprecated and marked for removal, usages are changed to new approach, including MP.
Documentation
Documentation updated both for SE and MP