Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC compatiblity fixes #9505

Merged
merged 1 commit into from
Nov 18, 2024
Merged

gRPC compatiblity fixes #9505

merged 1 commit into from
Nov 18, 2024

Conversation

spericas
Copy link
Member

Description

  • Special handling for identity compressor to ensure compress flag is not turned on. Identity compression is a special case, and for compatibility it should not be treated as a normal compressor.
  • If a gRPC service is not found, include ":status" header in response to comply with gRPC spec
  • A few null checks were missing in GrpcRouteHandler
  • New tests for all the changes above
  • Fixes issue No grpc reponse from Javascript client request #9452

Documentation

None

@spericas
Changes in this commit:
00e1a58 
- Special handling for identity compressor to ensure compress flag is not turned on. Identity compression is a special case, and for compatibility it should not be treated as a normal compressor.
- If a gRPC service is not found, include ":status" header in response to comply with gRPC spec
- A few null checks were missing in GrpcRouteHandler
- New tests for all the changes above
@spericas spericas added grpc 4.x Version 4.x labels Nov 18, 2024
@spericas spericas added this to the 4.1.5 milestone Nov 18, 2024
@spericas spericas self-assigned this Nov 18, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 18, 2024
@tjquinno tjquinno linked an issue Nov 18, 2024 that may be closed by this pull request
No grpc reponse from Javascript client request #9452
Closed
tjquinno
tjquinno approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see the PR adds tests with the GRPC_ACCEPT_ENCODING header. Maybe the GRPC_ENCODING header case does not affect/is not affected by the changes in this PR, but at some point it might be good to add tests for that case.

@spericas spericas merged commit 9e7a7e8 into helidon-io:main Nov 18, 2024
46 checks passed
@barchetta barchetta mentioned this pull request Nov 21, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees

@spericas spericas

Labels
4.x Version 4.x grpc OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
Archived in project
Milestone
4.1.5
Development

Successfully merging this pull request may close these issues.

No grpc reponse from Javascript client request
2 participants
@spericas @tjquinno