Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Remove unused code from SystemTagsManagerImpl #9532

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Captain1653
Copy link
Contributor

Description

Class MultiIterable is package private and is not used.

Should it be deleted?
Screenshot 2024-11-25 at 17 21 41

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 25, 2024
@Captain1653
Copy link
Contributor Author

Small note:
Field METRICS_CONFIG_OVERRIDES is not used in SystemTagsManagerImpl. Is it a bug or just unused variable?

@Captain1653 Captain1653 changed the title 4.x: Remove unused inner class MultiIterable 4.x: Remove unused code from SystemTagsManagerImpl Nov 28, 2024
@Captain1653
Copy link
Contributor Author

Can it be merged? Please :)

@romain-grecourt romain-grecourt merged commit 0a2e0b5 into helidon-io:main Dec 11, 2024
46 checks passed
@Captain1653 Captain1653 deleted the remove-multiiterable branch December 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants