Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inline images. #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added inline images. #21

wants to merge 3 commits into from

Conversation

nickssl
Copy link
Contributor

@nickssl nickssl commented Oct 6, 2019

Added inline images because sphinx cannot get the plot images using pyqt5.

nickssl and others added 2 commits October 5, 2019 21:09
@nickssl
Added inline images.
5e83ed7 
Added inline images because sphinx cannot get the plot images using pyqt5.
@nickssl
Merge branch 'master' into master
a47c7fa
@nickssl nickssl closed this Oct 6, 2019
@nickssl nickssl reopened this Oct 6, 2019
@nickssl
Copy link
Contributor Author

nickssl commented Oct 19, 2019

Can you accept this?

@Cadair
Copy link
Collaborator

Cadair commented Oct 19, 2019

Where is the requirement for pyqt5 coming from? Are they matplotlib plots?

@nickssl
Copy link
Contributor Author

nickssl commented Oct 19, 2019

Where is the requirement for pyqt5 coming from? Are they matplotlib plots?

It is using pyqtgraph: http://www.pyqtgraph.org/

@Cadair
Copy link
Collaborator

Cadair commented Oct 21, 2019

Ah right, I think it would be better if you uploaded the images to this repo rather than linking them across site. Is there a good reason to not do that?

@Cadair Cadair mentioned this pull request Oct 21, 2019
Closed
@Cadair
Copy link
Collaborator

Cadair commented Oct 21, 2019

I also added an issue on sphinx gallery to directly support pyqtgraph.

@nickssl
Copy link
Contributor Author

nickssl commented Oct 21, 2019

Ah right, I think it would be better if you uploaded the images to this repo rather than linking them across site. Is there a good reason to not do that?

The main reason I did not upload the images to the repository is that I did not want to make it large size on disk. If many people upload images then the source code will be too large. Of course, right now there aren't many examples, so this is not a real issue currently, and I can upload the images if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickssl @Cadair