AllDomains integration #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add TldParser to retrieve domain owner * add debounce to avoid unneccessary rpc calls * add alias/nickname as the domain when applicable
…ains-integration
…omains-integration
crypt0miester
requested review from
allenan,
matthewcarlreetz and
elsie-c
and removed request for
a team
|
+1 here |
|
Looks like this needs a rebase and some testing on iOS as there are a few bugs.
|
abhay
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gm team,
the ui bug has been fixed. the error was primarily being that the useDebouncedCallback was not working as intended. This has been fixed by implementing the debounce on incoming text rather than relying on useDebouncedCallback.
btw, I have noticed the same bug as shown by noah's recording when importing a wallet and writing it down as opposed to pasting.
regards,
miester.