White and Black & Black and White

[ChiefMateStarbuck]

This pull request introduces two new themes, white_and_black and black_and_white, to the runtime. They are monochrome, which will help those with vision impairment.

white_and_black is a light theme.

black_and_white is a dark theme.

[gj1118]

I tried the dark mode. Can you please change the theme in such a way that the code when the ruler and line highlight is turned on ?

[ChiefMateStarbuck]

I tried the dark mode. Can you please change the theme in such a way that the code when the ruler and line highlight is turned on ?

Hello. I don't seem to understand. Should the vertical and horizontal lines be different colors? Should the cursor also be a different color than the vertical/horizontal lines?

[gj1118]

I tried the dark mode. Can you please change the theme in such a way that the code when the ruler and line highlight is turned on ?

Hello. I don't seem to understand. Should the vertical and horizontal lines be different colors? Should the cursor also be a different color than the vertical/horizontal lines?

Yes please.

[ChiefMateStarbuck]

I tried the dark mode. Can you please change the theme in such a way that the code when the ruler and line highlight is turned on ?

Hello. I don't seem to understand. Should the vertical and horizontal lines be different colors? Should the cursor also be a different color than the vertical/horizontal lines?

Yes please.

Hello @gj1118. It's uncertain if this is possible with only 4 colors. I'm open to solutions. The vertical line has been slightly darkened.

[ChiefMateStarbuck]

@archseer @gj1118 Hello.
Any feedback?
I’m very willing to keep iterating on this. Just let me know what to fix.
CC . @the-mikedavis

[the-mikedavis]

It looks like most of the styles are shared between both themes. Can these use inheritance instead - one theme defines all of the styles and the other makes small overrides and changes the palette? The gruvbox themes are a good example of inheritance

[ChiefMateStarbuck]

hello, would like both themes to inherit from a base-theme, or for one theme to inherit from the other?

In the first scenario, would the base-theme be usable? The base-theme could be a less aggressive light theme.

[the-mikedavis]

I would just have one inherit the other. There isn't a way to make a base theme that doesn't show up in the :theme list

[ChiefMateStarbuck]

After extensive use with these themes, I find them to be abrasive and a pain on the eyes.

The light theme is too white. It's like reading letters on the suns surface.

Reading the white text on the dark screen also cause squinting and fatigue.

I would like to reject my on PR and close this out.