app: location: Use zbus subscriber instead of listener #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregersrygg
force-pushed
the
location-use-zbus-sub
branch
4 times, most recently
from
dc13ac9 to
6fda775
Compare
simensrostad
reviewed
Jun 4, 2024
| @@ -59,74 +72,49 @@ void location_task(void) | |||
| } | |||
|
|
|||
| err = location_init(location_event_handler); | |||
| if (err) | |||
| { | |||
| if (err) { | |||
| LOG_ERR("Unable to init location library: %d", err); | |||
There was a problem hiding this comment.
Suggested change
| LOG_ERR("Unable to init location library: %d", err); | |
| LOG_ERR("Unable to init location library: %d", err); | |
| SEND_FATAL_ERROR(); | |
| return; |
| static K_SEM_DEFINE(location_lib_sem, 1, 1); | ||
| static K_SEM_DEFINE(modem_init_sem, 0, 1); | ||
| static K_SEM_DEFINE(trigger_sem, 0, 1); | ||
| ZBUS_SUBSCRIBER_DEFINE(location, CONFIG_APP_LOCATION_ZBUS_QUEUE_SIZE); | ||
|
|
There was a problem hiding this comment.
Suggested change
| /* Forward declarations */ |
There was a problem hiding this comment.
This is unrelated to the PR.
| @@ -22,13 +22,10 @@ | |||
| LOG_MODULE_REGISTER(location_module, CONFIG_APP_LOCATION_LOG_LEVEL); | |||
|
|
|||
| BUILD_ASSERT(CONFIG_APP_LOCATION_WATCHDOG_TIMEOUT_SECONDS > | |||
| CONFIG_APP_LOCATION_TRIGGER_TIMEOUT_SECONDS, | |||
There was a problem hiding this comment.
Nit: Some alignment issues here it looks like. Could align with CONFIG_APP_LOCATION
app/src/modules/location/location.c
Outdated
| { | ||
| LOG_ERR("Unable to send location request: %d", err); | ||
| if (&TRIGGER_CHAN == chan) { | ||
| LOG_WRN("Trigger received"); |
There was a problem hiding this comment.
Suggested change
| LOG_WRN("Trigger received"); | |
| LOG_DBG("Trigger received"); |
gregersrygg
force-pushed
the
location-use-zbus-sub
branch
2 times, most recently
from
0b00ddb to
a0272de
Compare
Updated the location module to use zbus subscribe instead of a listener for consistency and easier logic. Removed semaphores and modem lib connection handling. Connection handling might be needed unless the location lib doesn't handle this internally, but it should probably be dealt with using the Zephyr State Machine Framework. Signed-off-by: Gregers Gram Rygg <[email protected]>
gregersrygg
force-pushed
the
location-use-zbus-sub
branch
from
a0272de to
f0545bd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the location module to use zbus subscribe instead of a listener for consistency and easier logic. Removed semaphores and modem lib connection handling. Connection handling might be needed unless the location lib doesn't handle this internally, but it should probably be dealt with using the Zephyr State Machine Framework.