Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inner content scoped slot #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wrabit
Copy link

@wrabit wrabit commented Oct 22, 2019

Hi!

Really like your plugin. Using it in a project at the moment and have had to adapt it for IE11 support (no ForeignObject, so I am using <text> in the svg). What I've done:

  1. Made the ForeignObject / default slot render only if default slot present (no breaking changes)
  2. Added a “inner-content” slot so we can use anything inside the SVG, in my case <text />
  3. New named slot has access to the radius value
  4. Updated the demo to show this

Would you consider a merge? 😶

p.s. ForeignObject crashes the whole page when used in IE11 (haven't tested the full scope of other browsers)

@wrabit
Copy link
Author

wrabit commented Oct 29, 2019

Reference to #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant