Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to add support for Elementor Pro widgets #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinkidwell
Copy link

@kevinkidwell kevinkidwell commented Jul 28, 2020

This is a great plugin that I was looking to use on some sites but it wasn't unregistering widgets from Elementor Pro. After some research, I followed what was listed in elementor/elementor#7256 (comment) as to the number following the unregister action.

Testing locally, this worked to remove widgets registered with Elementor Pro and I wanted to contribute back since it's a small change that others could use, as noted in #2.

@TestoriCus
Copy link

Hello, good idea!
For users with multiple plug-ins, however, it quickly becomes a guessing story which of these packs the widget comes from :-)

@lucanos
Copy link

lucanos commented Oct 23, 2020

This commit seems to have no effect on the Widgets shown in the Widget Manager to allow the User to turn them on/off. I just manually made the same change and the list of Widgets in the Widget Manager still fails to show Elementor Pro Widgets, and even WooCommerce Widgets. Even changing the order parameter to 999 failed to make any difference.

@takemeoutevents
Copy link

takemeoutevents commented Feb 4, 2021

Hi there,

I am not a developer just a girl who builds her own website. I have altered the array for unregistered widgets to 200 and now the pro widgets are also disapearing in the backend when i deactivate them using widget manager.

However...

If i check my pages on front end i can still see all the css for the deactivated widgets is loaded on my pages. This is creating an enormous amount of unussed css.

Is this normal?
Is there anything i can do to fix this?

Here is a vid to show you the css is still loaded in the front end

https://www.loom.com/share/054ee2fce4c0448d9c8fa85ac2a3a9e9

Help would be realy appreciated!

Kind regards,

Holly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants