Skip to content

Commit

Permalink
[frontend] chore: Change FE to use yarn
Browse files Browse the repository at this point in the history
  • Loading branch information
helloitsdave committed Jun 1, 2024
1 parent ae7e7bc commit 3e7a29e
Show file tree
Hide file tree
Showing 11 changed files with 12,579 additions and 22,527 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/frontend-component-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Install and Execute Component Tests
run: |
npm ci
npm run test:coverage
yarn
yarn test:coverage
- name: Coverage Report
uses: romeovs/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frontend-docker-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ jobs:
env:
IMAGE_TAG: ${{ steps.extract_version.outputs.VERSION }}
run: |
npm run docker:build
yarn docker:build
docker tag notes-app-fe:latest ${{ secrets.DOCKERHUB_USERNAME }}/notes-app-fe:$IMAGE_TAG
docker push ${{ secrets.DOCKERHUB_USERNAME }}/notes-app-fe:$IMAGE_TAG
6 changes: 3 additions & 3 deletions .github/workflows/frontend-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install packages
run: npm ci
run: yarn

- name: Run ESLint
run: npm run lint
run: yarn lint
6 changes: 3 additions & 3 deletions .github/workflows/frontend-service-tests-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
- name: Install and start frontend
run: |
cd ./frontend
npm ci
npm run build
npm run start &
yarn
yarn build
yarn start &
- name: Install Playwright
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/frontend-service-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ jobs:
- name: Install and start frontend
run: |
cd ./frontend
npm ci
npm run build
npm run start &
yarn
yarn build
yarn start &
- name: Install Playwright
run: |
Expand Down
4 changes: 2 additions & 2 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ARG REACT_APP_API_BASE_URL
ENV REACT_APP_API_BASE_URL=$REACT_APP_API_BASE_URL

# Build the app
RUN npm run build
RUN yarn build

# Use an official lightweight Node.js runtime as the final base image
FROM node:14-alpine
Expand All @@ -27,7 +27,7 @@ FROM node:14-alpine
WORKDIR /usr/src/app

# Install serve to serve the app
RUN npm install -g serve
RUN yarn global add serve

# Copy the build output from the previous stage
COPY --from=0 /usr/src/app/build .
Expand Down
Loading

0 comments on commit 3e7a29e

Please sign in to comment.