Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add k8s-spot-termination-handler chart #10494

Closed

Conversation

QuingKhaos
Copy link
Contributor

What this PR does / why we need it:

Adds a chart for the K8s Spot Termination handler which watches the AWS metadata service when running on Spot Instances.

Which issue this PR fixes

Special notes for your reviewer:

Could this go already straight to stable?

I hope the OWNERS file is ok/correct/allowed?

Checklist

  • DCO signed
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmiiKhaos
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: seanknox

If they are not already assigned, you can assign the PR to them by writing /assign @seanknox in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QuingKhaos
Copy link
Contributor Author

/assign @seanknox

@max-rocket-internet
Copy link
Contributor

We already have this, no?

https://github.com/helm/charts/tree/master/stable/k8s-spot-termination-handler

It's missing a readme though. Maybe you could create a PR to update that chart? Would be faster anyway as it seems PRs to add new charts are taking 30-60 days to be reviewed and merged.

@QuingKhaos
Copy link
Contributor Author

Oooooooooooooh, didn't checked the repo between the last PR and simply recreated it 🙈

Will create a proper new PR :)

@QuingKhaos QuingKhaos closed this Jan 9, 2019
@QuingKhaos
Copy link
Contributor Author

@max-rocket-internet see #10496

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart
5 participants