-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/prometheus-operator] add instance-namespace paramters to scope api interaction for CRs #23434
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikonse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mikonse. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Michael Loipfuehrer <[email protected]>
/assign @vsliouniaev |
/hold Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great! |
Also probably a good idea to add a PR to update the docs ☝️🙂 good catch |
@mikonse as a user and contributor, would you mind helping to review/test this PR? prometheus-community/helm-charts#1 No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Thanks! |
🚧 This chart is now deprecated. Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the If applicable, please re-open this PR there. Thanks! |
Is this a new chart
no
What this PR does / why we need it:
Implement command line arguments of prometheus operator to scope api interactions for Alertmanager, Prometheus and ThanosRuler CRs. These arguments take precedence over the normal namespace scope parameters.
These flags are not yet fully documented in Prometheus Operator but can be found here in the source code.
Checklist
[stable/mychartname]
)