-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/prometheus-operator] Default Backend config in ingress #23446
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karthikm83 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @karthikm83. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: karthikm83 <[email protected]>
Signed-off-by: karthikm83 <[email protected]>
Signed-off-by: karthikm83 <[email protected]>
Signed-off-by: karthikm83 <[email protected]>
Signed-off-by: karthikm83 <[email protected]>
/assign @vsliouniaev |
/hold Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great! |
@karthikm83 as a user and contributor, would you mind helping to review/test this PR? prometheus-community/helm-charts#1 No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Thanks! |
🚧 This chart is now deprecated. Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the If applicable, please re-open this PR there. Thanks! |
Is this a new chart - NO
What this PR does / why we need it:
This PR will enable a feature to configure default Backend for Ingress objects.
This will be useful especially in Google Kubernetes Engine, as GKE Ingress is using kube-system's default-http-backend service as a default backend for Load Balancer if not specified, and hence becoming difficult to manage the ingress the way we want.
Which issue this PR fixes
fixes # 23202
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)