-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/prometheus] Unify labels and annotations #23689
Conversation
…ts and statefulsets Signed-off-by: Ondrej Homolka <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hmlkao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @hmlkao. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Xtigyro |
{{- end }} | ||
labels: | ||
{{- include "prometheus.server.labels" . | nindent 8 }} | ||
{{- if .Values.server.statefulSet.labels}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed according to current Deployment template.
.Values.server.statefulSet.labels
is used to add labels to StatefulSet itself, not pods.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmlkao Thanks for the contribution!
Could you please add all the deploymentAnnotations
in the values.yaml
file?
@hmlkao Also - we're in the middle of a transition to a new repo for the Prometheus Helm charts. Where would you like this PR to be merged - here or in the new repo (https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus)? |
See #23692. We're ready to deprecate stable/prometheus in favor of the new repo. Can this PR please be opened over there instead? |
@hmlkao The only option has become the new repo. Please open the same PR there if it's okay for ya. Apologies for the double effort! @scottrigby Agreed. |
Well, I've created PR in new repo and add requested additions |
Is this a new chart
No
What this PR does / why we need it:
This PR unify labels and annotations across all deploymets and statefulsets in stable/prometheus Helm chart
+ removed useless trailing pipe chars (|) in README.md
Checklist
[stable/mychartname]
)