Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added docs for multi-platform plugin hook support #1627

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

stevehipwell
Copy link
Contributor

What this PR does / why we need it:
This PR adds the docs for helm/helm#12962.

Special notes for your reviewer:
I've tried to align the plugin docs to the chart docs.

@stevehipwell
Copy link
Contributor Author

CC @sabre1041

@sabre1041
Copy link
Contributor

CC @sabre1041

will review again in next 24-48

@stevehipwell stevehipwell force-pushed the add-plugin-platform-hooks branch from 261b428 to c776e03 Compare October 17, 2024 08:18
@stevehipwell
Copy link
Contributor Author

Thanks for your review @TerryHowe, I've addressed your comments.

Copy link
Member

@gjenkins8 gjenkins8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating!

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can integrate it as soon as the related PR is merged and released

@stevehipwell stevehipwell force-pushed the add-plugin-platform-hooks branch from c0d38ca to f9e07c2 Compare November 20, 2024 13:27
@stevehipwell stevehipwell force-pushed the add-plugin-platform-hooks branch from f9e07c2 to 1b5a8dd Compare November 21, 2024 17:29
@yxxhero yxxhero merged commit a417fec into helm:main Dec 19, 2024
2 checks passed
@stevehipwell stevehipwell deleted the add-plugin-platform-hooks branch December 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants