Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add choerodon helm repo #101

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Add choerodon helm repo #101

merged 1 commit into from
Jun 3, 2019

Conversation

vinkdong
Copy link
Contributor

@vinkdong vinkdong commented May 29, 2019

Add helm repo for choerodon project.

Signed-off-by: vinkdong <[email protected]>
@mattfarina mattfarina merged commit 3867bcf into helm:master Jun 3, 2019
@mattfarina
Copy link
Contributor

@vinkdong I noticed all the descriptions read "A Helm chart for Kubernetes". It would be worth putting a real description on the charts.

@vinkdong
Copy link
Contributor Author

vinkdong commented Jun 3, 2019

@mattfarina Thanks for pointing, I will improve it as soon.

@scottrigby
Copy link
Member

scottrigby commented Aug 22, 2020

@vinkdong I just emailed you about a name change request for a chart in your repo. I don't see where the chart source code is so unclear where else to make an issue. Thanks in advance.

I want to make you aware of a change happening in the prometheus charts, which includes a rename request (from "prometheus-operator" to "kube-prometheus"). The stable/prometheus-operator chart (and charts like yours https://hub.helm.sh/charts/choerodon/prometheus-operator that were originally copied from stable) was incorrectly named, since it installs the https://github.com/prometheus-operator/kube-prometheus project, of which prometheus-operator is only one component.

We would request that you update the chart name, and deprecate the older one. There is a specific process to go through for that, which will de-list the old name from the Helm Hub.

I filed a similar issue with bitnami here bitnami/charts#3490 which explains the issue, and links to mode details.

Please let me know if you'd like to chat in real time – on twitter, slack, discord, etc – if you have questions about the process for deprecating/renaming correctly so the chart is hidden in Helm Hub.

Here are some issues/comments if you want to see more details and context:

@vinkdong
Copy link
Contributor Author

@scottrigby Thanks for reminding us, we have deprecated our prometheus-operator.

@scottrigby
Copy link
Member

@vinkdong Thank you 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants