popm/wasm: improve js.Value creation, add JSMarshaler interface #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: refactor
ClaytonNorthey92
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
hey @joshuasing my feedback here is optional; I would just suggest adding some unit tests especially for jsValueSafe. There seem to be a lot of conditions there, it seems like a (very) good candidate for table driven tests of what to expect. and I feel that we should protect ourselves here.
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve
js.Valuecreation in the WebAssembly PoP Miner, addJSMarshalerinterface.Changes
jsValueOfandjsValueSafeJSMarshalerinterface which can be used to implement custom logic for converting a type into ajs.Value