PoP stats service #172
PoP stats service #172
Conversation
gabmontes
force-pushed
the
pop-stats
branch
2 times, most recently
from
837e7f5 to
28cc77b
Compare
gabmontes
changed the title
There was a problem hiding this comment.
Looks good. I have left a few comments.
There is also a PNPM workspace already setup under the web/ directory, with ESLint and Prettier already setup. What do you think of moving this to web/packages/pop-stats/? I think this would help keep everything tidier and more consistent.
joshuasing
added
type: enhancement
|
@joshuasing the What we should do is to update its configuration to match the standards in regards to linting and formatting we use in all the other JavaScript repos at Bloq and Hemi. |
There was a problem hiding this comment.
Looks good, a few things I missed on my first pass. Will any GitHub Actions be added for this service?
The node.yml file already builds the packages in web/, a separate job could be added there that builds this module.
I assume the Dockerfile will also need to be built for releases, would you like me to make a pull request to add building this to the release.yml action once this has been merged?
|
@joshuasing GitHub Actions to automatically build the Docker image could be added later. I will define that with @dhidalgX and send a PR or ask you for help. Thanks for pointing that out! |
Co-authored-by: Gonzalo D'Elia <[email protected]>
* Add PoP stats service * Improve Dockerfile, scripts and docs * Add popstats folder code owner * Improve docs Co-authored-by: Gonzalo D'Elia <[email protected]> --------- Co-authored-by: Gonzalo D'Elia <[email protected]>
Summary
This PR adds a service that will collect all the PoP payout transactions, summarize and report to Absinthe.
See the README file for details.
Related to #170.
Changes
Add everything to the
/popstatsfolder. No additional changes to the repo.