Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popm/wasm: add 'minerStatus' method #178

Merged
merged 1 commit into from
Jul 15, 2024
Merged

popm/wasm: add 'minerStatus' method #178

merged 1 commit into from
Jul 15, 2024

Conversation

joshuasing
Copy link
Contributor

@joshuasing joshuasing commented Jul 12, 2024 •
edited
Loading

Summary
Add a minerStatus method to the WebAssembly PoP miner that exposes the whether the miner is running, and whether the miner is currently connected to the BFG server.

Closes #171

Changes

  • Add minerStatus method to the WebAssembly PoP miner and @hemilabs/pop-miner package
  • Add Connected() function to the PoP miner that returns whether the miner is currently connected to BFG
  • Add readonly to event fields in @hemilabs/pop-miner package

@joshuasing joshuasing added type: feature This adds new functionality size: S This change is small (+/- <80) labels Jul 12, 2024
@joshuasing joshuasing requested a review from a team as a code owner July 12, 2024 13:14
@github-actions github-actions bot added area: popm This is a change to popm (PoP Miner) area: popm/wasm This is a change to the WASM popm (PoP Miner) area: @hemilabs/pop-miner This is a change to the @hemilabs/pop-miner NPM package labels Jul 12, 2024
jcvernaleo
jcvernaleo approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@joshuasing joshuasing merged commit 383611f into main Jul 15, 2024
6 checks passed
@joshuasing joshuasing deleted the joshua/popm/minerRunning branch July 15, 2024 14:41
web3cryptoguy pushed a commit to web3cryptoguy/heminetwork that referenced this pull request Nov 1, 2024
@joshuasing
popm/wasm: add 'minerStatus' method (hemilabs#178)
f709627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gndelia gndelia gndelia approved these changes

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@ArturDolzan ArturDolzan ArturDolzan approved these changes

@marcopeereboom marcopeereboom Awaiting requested review from marcopeereboom

Assignees
No one assigned
Labels
area: @hemilabs/pop-miner This is a change to the @hemilabs/pop-miner NPM package area: popm/wasm This is a change to the WASM popm (PoP Miner) area: popm This is a change to popm (PoP Miner) size: S This change is small (+/- <80) type: feature This adds new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popm/wasm: add method to check if pop miner is running
5 participants
@joshuasing @gndelia @jcvernaleo @ClaytonNorthey92 @ArturDolzan