bfg,bss: add pagination to PoP txs and payouts #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: bfg
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
joshuasing
added
type: refactor
joshuasing
reviewed
Aug 5, 2024
ClaytonNorthey92
changed the title
joshuasing
reviewed
Aug 6, 2024
joshuasing
approved these changes
Aug 6, 2024
max-sanchez
approved these changes
Aug 13, 2024
This comment was marked as spam.
This comment was marked as spam.
ClaytonNorthey92
force-pushed
the
clayton/poptx-pagination
branch
from
ebc8bfa to
8e61e89
Compare
allowing pagination of flow bss.popPayouts --> bfg.popTxsForL2Block
ClaytonNorthey92
force-pushed
the
clayton/poptx-pagination
branch
from
08628d9 to
5a50cac
Compare
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* allow pagination of pop payouts allowing pagination of flow bss.popPayouts --> bfg.popTxsForL2Block * small cleanup * updated error handling to be single line * pr feedback * checking number of unique results * deep equal arrays of miner addresses in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
allowing pagination of flow bss.popPayouts --> bfg.popTxsForL2Block
Changes
added pagination to aforementioned logical path
IMPORTANT: optimism will need to be updated to include pagination otherwise this will limit request to 100 results
fixes #195